| [00:55:16] | * BenK_ has left #drupal-games () |
| [05:55:05] | * Berdir has joined #drupal-games |
| [06:37:51] | * seutje has joined #drupal-games |
| [06:37:51] | * seutje has quit (Changing host) |
| [06:37:51] | * seutje has joined #drupal-games |
| [13:34:23] | * Berdir has left #drupal-games () |
| [13:53:50] | * BenK_ has joined #drupal-games |
| [15:28:51] | * seutje has quit (Quit: yarrrr, here be the end!) |
| [16:22:55] | * Berdir has joined #drupal-games |
| [16:24:39] | <Berdir> | BenK_: hey |
| [16:24:55] | <BenK_> | Hey there! |
| [16:27:33] | <BenK_> | Haven't seen you in the issue queues quite as much... been busy with other stuff? |
| [16:28:01] | <Berdir> | yeah :) |
| [16:28:32] | <Berdir> | I know, I'm behind :) |
| [16:28:48] | <Berdir> | I've been mostly working on core issues or private stuff |
| [16:29:06] | <BenK_> | I'm testing the User Relationships stuff now... |
| [16:31:15] | <BenK_> | Do you have a minute for a quick question unrelated to the modules we usually work on? I'm trying to figure out a comment from fago that I don't fully understand... |
| [16:31:27] | <Berdir> | sure |
| [16:33:30] | <BenK_> | Basically, I've been testing a D7 port of Content Access and fago says there are lots of problems in the code. But I can't quite understand what he's saying the problems are... His comments are located here (and they reference the attached patch): http://drupal.org/node/690610#comment-3401602 |
| [16:33:31] | <Druplicon> | http://drupal.org/node/690610 => Port to Drupal 7 => Content Access, Code, normal, needs work, 57 comments, 1 IRC mention |
| [16:38:15] | <Berdir> | hm, can't really say much ;) coding style stuff, patch is outdated and some strange code :) |
| [16:41:05] | <BenK_> | Okay, thanks. I was trying to understand the purpose of the strange code. But I guess I will have to investigate further... ;-) |
| [16:42:33] | <Berdir> | the (int)($op == 'view') is probably required because the arguments are directly passed to the db layer and that requires an 1 instead of TRUE. D6 does automatically convert that. But should probably better by enforced by acl.module itself |
| [16:48:36] | <BenK_> | Oh yes, I remember now... that was suggested by the ACL module maintainer himself here: http://drupal.org/node/824642#comment-3080112 |
| [16:48:37] | <Druplicon> | http://drupal.org/node/824642 => D7: Error Message When Viewing a Node's "Access Control" tab (ACL with Content Access module) => Content Access, Code, normal, active, 6 comments, 1 IRC mention |
| [16:49:17] | <BenK_> | So I guess I will need to explain to fago... |
| [16:51:41] | <BenK_> | Thanks for that! :-) |
